They can't last "forever" because if they did there wouldn't be any increased iron in people's diet!
"One Lucky Iron Fish can provide an entire family with up to 75% of their daily iron intake for up to 5 years".
So we'll need to replace them a bit more often than that (not that I'm saying it's not a good cause).