Comment by sagichmal | Hacker News Reader

Comment by sagichmal | Hacker News Reader

Parent Full thread

    > What random formatting?

Primarily here I saw a lot of arbitrary indentation. As far as I can tell, everything would be fixed by a gofmt -w...

https://github.com/andlabs/ui/blob/master/button.go#L16-19

https://github.com/andlabs/ui/blob/master/area_unix.go#L35-3...

https://github.com/andlabs/ui/blob/master/area_unix.go#L107

https://github.com/andlabs/ui/blob/master/area_unix.go#L200

https://github.com/andlabs/ui/blob/master/area_unix.go#L329-...

https://github.com/andlabs/ui/blob/master/grid.go#L18-26

    > What unidiomatic naming conventions?

Primarily here I saw a lot of underscores, which are never used in pure Go. Some of that maybe is due to Cgo conventions, but some of it isn't.

https://github.com/andlabs/ui/blob/master/area_unix.go#L209

https://github.com/andlabs/ui/blob/master/sysdata.go#L23

All indentation ones except the L35-37 ones are lack of go fmt. I will go fmt once I can double-check exactly what go fmt changes.

L35-37 I'm not sure what problem that has; I just put the very long bitmask on its own line.

The underscores in our_xxx_xxx_xxx I don't think would be much of an issue. They unintentionally match the GTK+ naming conventions. I don't know why I did them, but I don't consider it a world-ending issue worth fixing. Same for _xSysData, but in that case the _ is there in case I accidentally said xSysData somewhere else.

Reply on news.ycombinator.com