Ok, I'm an idiot but how would you rewrite getDayOfWeek?
2: not 0-indexed (there can be good reasons for this, but the context of the function should at least suggest the reason)
3: Doesn't handle errors - should throw IllegalArgumentException, and if should do it in the default handler of the switch. If you suddenly see "???" in the UI, it's not easy to track down to this.
4: If for some valid reason this can't be a library function, it should be an enum, and it should be used throughout the code.
enum DayOfWeek {
MONDAY(1, "Monday"), TUESDAY(2, "Tuesday") ...
public int id;
public String displayName; // these should be private and have getters according to most style-guides.
public DayOfWeek(int id, String displayName) {
this.id = id;
this.displayName = displayName;
}
public static DayOfWeek fromId(int id) {
for (DayOfWeek d : values()) {
if (d.id == id) return d;
}
throw new IllegalArgumentException("Illegal DayOfWeek id passed: " + id);
}
}FTFY
Maybe that's a bit of a long shot. Perhaps there's some standard library function -- I don't know Java, but the author seems to assume the reader does throughout the article -- to turn dates/whatever into day number. Maybe his joke is therefore, "OMFG! What a noob!"
In short: I don't get it, either...
"data" is ambiguous, too. I think that perhaps there are a few errors to demonstrate his point.
calendar.getDisplayName(Calendar.DAY_OF_WEEK, Calendar.LONG, Locale.US)
Not that it's necessarily nicer, but generally I'd say duplicating functionality of the standard libraries or frameworks should be avoided if possible.
Assuming that the input string is a formatted date of some sort, then I think this would work, using JodaTime (minus exception handling):
public String getDayOfWeek(String s) {
DateTimeFormatter formatter = DateTimeFormat.forPattern("dd/MM/yyyy");
DateTime dt = formatter.parseDateTime(s);
return dt.dayOfWeek().getAsText();
} String[] names = { "UNUSED", "Monday", "Tuesday", ... }
try {
return names[i];
} catch(ArrayIndexOutOfBoundsException uhoh) {
return "???";
}
Look, at least it's not a pile of @Inject DayOfWeekLookupAdapter dayOfWeekLookupAdapter with attendant 100kB Spring XML config, of which the unit tests will have their very own special cut and pasted copy. No, I'm not bitter at all.