Kamele PHP Framework. Small framework. Much awesome.
github.com
github.com
* Uses arcane define() statements to set configuration
* No ORM -- provides a slim wrapper around mysqli
* Uses singleton classes -- makes any potential unit testing very cumbersome
* Rudimentary routing system -- doesn't support anything beyond /$CONTROLLER/$ACTION/$ARGS...
* Rudimentary templating system that does simple string-replacement -- doesn't support looping or conditional control structures
* Database::safeQuery() is anything but safe, in fact it's quite dangerous -- prepared statements should be used at a minimum rather than blind string replacement (see mysqli::prepare())
This seems like it was an interesting learning exercise for the author, but it's not much beyond that.
The next step would probably be to make it PSR-1 and PSR-2 compliant (note how public/private accessors are absent in many places, and indentation swaps between spaces and tabs), and make it fit within the composer packaging system.
It was an interesting learning experience, and I don't think I'm done yet. But I thought maybe some people think it's interesting, and it turns out some do. (See the number of upvotes/stars/comments)
PSR-1 and PSR-2 is not my style. Indentation sucks, I'll change that, but I will not change everything into PSR compliant code. Again: simplicity. I am pretty constant in my code style, so that can't be an issue.
I disagree quite strongly with not trying to adhere to composer packaging guidelines, since it's common to many PHP developers (especially those on HN) that using it shouldn't be an issue.
Also, tying into composer would help you as a developer as well -- there is a very large body of packages available that are quite stable and reliable.
A lot of what I went over is mostly semantics/preference, however those are important to me. No shame, no guilt -- just constructive criticism.
I'll look at composer, that certainly looks promising. (But quite hard too...)
I'm always in for some constructive criticism, you do have valid points. But the thing is this framework isn't designed to be professional, it's designed for a simple copy-paste-program workflow. (Or in this case: 'git clone'-program). I never intended to write a great framework that can be used in any situation and is exactly following the standards to the last indentation, so that's not where I'll put my effort into. Big mistakes, however, like the Database::safeQuery(), are worth fixing. At first I didn't have events too, until someone alerted my that might come in handy, so I added it, and I am sure I'm going to use that one a lot.
> Not a composer package
Thats like saying "its not web 2.0" frankly. If you can't manage to checkout a library/framework and make use of it without being reliant on a specific package manager, you shouldn't be writing software.
> Uses arcane define() statements to set configuration
I don't think you know what arcane means.
Also, using constants to set application options can work very well if used properly.
> Uses singleton classes
I'd much rather a project that makes smart use of Singletons than the ridiculous SuperMegaObjectFactoryConstructorHelperFactoryFactory shit that is apparently the "in" thing.
> make it PSR-1 and PSR-2 compliant
PSR is a fucking joke. Code consistency within a project is important. Between a million different projects? Not so much.
The "goal" of PSR has never been "hey heres the best way to do things". Its purely an exercise in documenting the MOST COMMON way a set of projects do things.
> make it fit within the composer packaging system
Also, the author must only eat fishes on fridays and must devote his sunday to the FSM.
Composer is not jesus, PSR is not the bible. Stop acting like they are magical items sent from the heavens.
Honestly, I would not start a new project with a library that does not support composer if I could help it. Supporting composer is easy and makes my life easy - not because I /can't/ checkout the library, but because I don't have to store the library in my VCS and I don't have to bother with transmitting it back and forth between servers or dealing with Pull Requests with massive file changes whenever I update the library.
* No unit tests
Most of the problems people have listed could be solved easily with the ability to import packages and manage autoloading through composer and psr-4. If you're going to create your own templating system, you're going to have to put forth a pretty decent argument against using Twig, for instance, which has autoescaping, inheritance, functional extensions and a sandbox. I think probably you've done what a lot of people do and tried to reinvent too much - as a result, the framework is not modular enough to meet various other users' needs. It does work, I don't doubt, but other things work better, and this is an issue facing anyone building a PHP framework.
Some documentation letting us know why you built this, how to use it, what it's strengths and weaknesses are compared to other frameworks, etc. would certainly be useful, as would a more standard open source license (MIT.)
If you believe in it, keep working in it though.
Using proper namespaces would be great, the `System` namespace will probably collide with other projects. `Kamele\System` would be much better.
Using PDO would be much better than the `mysqli` functions.
Where are the unit tests?
What I am thinking of is pretty much the Do What the Fuck you Want to Public License, but only keeping that license itself. It's hard to find that...
Not sure why the documentation isn't included in the readme.
>It's a PHP framework. It works. Cool.
Tells me nothing.
I'm sorry, I will include this link right now in the README.md
http://kohanaframework.org/index
Note: I tend to use frameworks largely to enforce safe db queries. IIRC, Kohana does all the needed escaping transparently. Might seem like an overkill but it is better than relying on the discipline of individual developers.
Kamele does have a nice Database class that handles the PDO-object in a MySQLi-like way of approching the object. Especially the Database::safeQuery() function will be interesting for you: https://github.com/goldenice/Kamele-Framework/blob/master/sy...