As far as I know, none of the NSA's practices have been ruled unconstitutional. At best, the courts have sent mixed signals, and the collection of metadata was explicitly decreed constitutional by a precious Supreme Court ruling.