Hacker News Reader

Comment by cocoflunchy | Hacker News Reader

Looks nice, but I'm not sure what to make of this when underscore.js has a 0.0 score (https://codeclimate.com/github/jashkenas/underscore/trends).

View on HN

The GPA is calculated based on the ratings of the JS files in the repo. Underscore has only one file, which is an F, leading to the 0.0.

Here's the report for the underscore.js file with the specific issues that were identified: https://codeclimate.com/github/jashkenas/underscore/undersco...

Many of the complaints are due to the opinion that the braceless if is bad:

    if(foo) bar();

I understand why you may think

    if(foo) { bar(); }

is better, but it's unnatural for most people

Yeah we don't have a strong opinion on the matter. The lack of braces can lead to bugs when attempting to expanding the code in the conditional, as has been the case since the C days IIRC.

The linting is configurable to projects preferences, by checking in a .jshintrc file.

Speak for yourself, I find the absence of braces to be very unnatural.

I should add: When you have a ton of code in a single file, Code Climate will start to assess penalties. The idea is to try to approximate how maintainable and approachable a given piece of code would feel to a developer who is looking at it. It's not perfect, but very large files tend to be harder to maintain in general.

So Underscore's choice to be single file effectively dooms it from the start. Ember.js, on the other hand, is larger but more decomposed and scores fairly well.

and the underscore.js page at Travis-ci:

https://travis-ci.org/jashkenas/underscore

(funnily enough also been produced on a bluebox.net machine)

nevertheless overall this looks very promising - great UI design

Reply on news.ycombinator.com