The community seems to be split. I lean towards separating code by features. Having Controllers, Directives, Services in one file as long as it relates to a particular feature. You can have separate files for shared features.