One thing I had to learn the hard way is that a spin lock is a bad fit the moment your threads can be preempted mid critical section. Under oversubscription you're spinning against a thread that isn't even scheduled.