Hacker News Reader

It's an older code, but it checks out.

I would say that it is ambiguous code.

The first C project that I worked on used this a lot. Its definitely not the easiest to understand when coming from a C++ background (because no parameter declaration means no parameters) or from other descendant languages.

It's actually not ambiguous code at all. It's perfectly well-formed and unambiguous with respect to the C standard.

What it is, however, is hard-to-read and -maintain code.

I think it's a case of not having the compiler warning level set to it's highest level (which it should be) or the bad habit of some programmer's ignoring warning messages.

It is a bad code.

It was quite ok.

This is another proof that as programmers we need to learn and improve constantly :)