Hacker News Reader

Hacker News

Comment by strangetimes | Hacker News Reader

Parent Full thread

strangetimes

Guido apparently wrote a web-based code review tool for Google:

http://www.niallkennedy.com/blog/2006/11/google-mondrian.htm...

View on HN

http://code.google.com/p/rietveld/

I heard that this tool was not well received at Google; anybody else hear this?

Git is not well received at Google either.

Care to elaborate? I'm curious to hear why this might be.

This is not true. I use git practically every day, working within the main source tree. Google's a big company with thousands of engineers and multiple ways of doing things. Some use git, some don't. You use what works best for you.

Not true, a lot of people, including me, use git at Google. It's not a default options, but you can use it if you want to.

When I was there, everyone I knew used it and sang its praises.

But it is a large company with a lot of teams. I am sure there were people somewhere who thought it was awful.

When it worked, it was great. When it was down or slow (Friday at 4:15 PM, anyone?), it was miserable.

Hey wait, doesn't everybody at Google stay till 10:00 PM on Friday??!

Still need to beat the pre TGIF rush. Reviewing code after happy hour is a bad idea.

They kinda kick everybody out on Friday evenings, actually. (Not actually kick out, but make it easier to just go home, especially as compared with Mon-Thurs.) And, in fact, that's even more true now than it was two weeks ago, because of a change in food-service policy.

I use Rietveld (not in Google) and I'm not particularly impress. It makes the job, but I don't think is a GREAT tool. After all, there are not many ways you can do a code review...

I'd love something that will be more integrated with source control (git in particular), maybe I'm asking too much...

Try Gerrit. It's tightly coupled to git, it's quite easy to host, similar to Rietveld/Mondrian in style, and has good documentation.

Not true, it is a part of the required standard check-in process for the long time and just recently was replaced with the V2.

LGTM

Reply on news.ycombinator.com