Hacker News Reader

Comment by giancarlostoro | Hacker News Reader

The other issue with code review, and I'm glad I've not worked with people like this anymore, for the person being reviewed: NOBODY IS ATTACKING YOU, nobody is saying your code is bad, the goal is to do a once-over for quality.

Another goal people often miss:

It's okay to ask "stupid questions" and I would argue as a Junior, ask away, even if no code changes happen, ASK. Kind of follows the spirit of the original post, which is, can you maintain this?

View on HN

>NOBODY IS ATTACKING YOU

Somehow this captures a lot of the culture for me.

Places I work at weed out for this. If people cant take peer review they sour the workday for others.

You were not hired to write perfect code, relax.

Not true. I’ve attacked people before in the sense I was disgusted with the short cuts they took and the things they tried to get away with in the code.

I’ve seen the malicious deletion of features in order to stay hidden and I’ve called it out.

That's not always an attack though, at least in a constructive critical review, maybe the approach could be different, but I'm also talking about when people are leaving comments that are genuine, professional, and tone is fine. In your case, yes you are attacking them I suppose, even though you don't really need to, you just need to rejec the PR and comment "hey, are you sure this is right?" and substantiate it. Sometimes people don't realize.

Reply on news.ycombinator.com