For those that haven’t seen this very well done write up about Tahoe’s use of icons, I would definitely recommend it: https://tonsky.me/blog/tahoe-icons/
Main lesson seems to be, it's good to put icons on the standard, most frequently used actions. And make them colorful. That helps the eye find them.
Edit: also consistency and legibility. So basically "don't design it so it's bad!"
"On the upside: it’s not that hard anymore to design better than Apple!"
Good one to keep in mind.