Hacker News Reader

Not without heavy js code

Well, I actually submitted a pull-request almost a year ago but it was rejected for "complexity"...

I didn't understand that decision back then and I don't understand it today. The patch weighs in at about 100 lines which doesn't seem heavy to me. Especially when you consider that without the patch the bootstrap-"modal" is not a modal...

Anyway, here's the fixed bootstrap-modal.js for the version that was current back then:

https://gist.github.com/0d04646ab6cf4df50610

Line 23-82 is the important bit, that snippet is lifted nearly 1:1 from jquery.ui.dialog which fixed this issue ages ago. Beyond that there's only a couple lines of glue code.

Feel free to port this forward to the current version (or better-modal). Personally I've stopped using the javascript parts of bootstrap because I don't want to maintain forks for basic bugs like that.

You might want to change the language/syntax highlighting of that gist. That apostrophe on line 120...

Sorry, here's the same gist with proper syntax highlighting https://gist.github.com/bca7185d4cf0b71bd55b

Thanks for this. Currently I have a workaround by using data-tabindex instead of the standard tabindex but I've been trying to find a more robust solution to this problem so I'm going to take a look at implementing something like this.

Reply on news.ycombinator.com