As always, the question is not "do this for solar, or not?". The question is, "Is this a valuable & efficient way to store energy?".

It has to compete with pumped weight (usually water), pumped heat (salt, water, or underground), electric batteries, and so on.

So, as always, it's complicated.