This a no-brainer for buildings with high energy use. But we looked into getting a heat pump last year but it doesn't pan out because our house (15 years old) has a very low energy use and we would not recover the costs (about 20K euros after subsidies) for 20+ years.
New homes with mandated PV and battery, that's another story.
I paid for it anyway - my furnace was 50 years old (probably 60% efficient when new), and I have no idea how bad the AC was. That said, for less money I added more insulation to my house and that has a better ROI. (unfortunately the design of the house doesn't allow for even more insulation even though I could save a lot more if it could be done)
They also always stop the savings estimates right before the expected lifespan of the heatpump, at which point you have to buy a new unit which destroys the actual savings
Heat pumps are like pellet stoves in Europe a few years ago, the day the subsidies go away nobody wants them anymore.