Hacker News Reader

HNHacker News

Top New Best Ask Show Jobs

Comment by justinclift | Hacker News Reader

Parent Full thread

justinclift·

GitLab also limits the size of PRs/MRs, which makes it Unfit for Purpose. :( :( :(

Its a problem they know about, but have no plan to fix before 2027.

View on HN

I mean, the PR limit is like a million characters. I would also reject a PR of a million characters. That’s bananas.

Not sure about that "million characters", but we've been bitten by it in our production systems. :(

Thus, we're moving off GitLab.

I'm sure, I looked it up.

What use case does a million character PR have?

When an automated system creates a PR for merging from an existing dev branch (that's been extensively tested) to "master" (or "main").

The "surprise, you can't review all the files in your PR" using GitLabs standard web based tooling makes it a no-go.

That's interesting because GitHub's web UI craps out at much less than 1 million lines. It refuses to open even low thousand line diffs.

Yeah, agreed it's not great for that. I'm not real happy with GitHub's worsening UX either, but it'll at least show the _names_ of all the files in the PR.

With GitLab, when you hit the rate limit, any file "past" that limit doesn't even show that it exists in the MR. It just looks like the MR is missing a bunch of stuff, with no workaround available. :( :( :(

I’ve personally been deeply unappreciated of Github’s changes in the last few years to automatically not show diffs to “large files” without having to click to open them - which seems to be a threshold that continues to shrink. Maybe like 3 screenfuls of content is the limit now per file. It’s crazy.

Reply on news.ycombinator.com