I see a lot of reasons to think otherwise:
According to the article, regular balls are already being donated but usually go flat quickly. This basically means donations are currently being wasted. If this wasted money can be redirected into something which will not be wasted, that seems like a definite win.
Further, balls are not just used for neighborhood games, but by organizations which use football as a tool for reaching other goals. If these organization are at all helpful, scrounging in the trash for materials to make balls is probably not a good use of their time. An organization may need dozens of balls, and if a trash ball only lasts for an hour (just a guess, I've never played football with a trash ball), then they may need over a hundred of them a day. The opportunity cost of the time spent making trash balls is probably higher than the cost of these balls, especially if they can truly last for years.
You could apply the same thinking about opportunity cost to the children's time. If play is important for children and if making balls out of trash is not play, then giving them more time to focus on play is a win.
Having cool things seems to be universally enjoyable. This gives the children something cool, probably adding to the fun of playing.
Digging in the trash is probably a lot less safe than playing football.
According to the corporation's website, 20 million deflated balls are discarded in Africa every year. If these balls last longer, there will be an environmental impact.
And finally, the main ways other charity attempts backfire (economic damage, not meeting the whole need [providing things the community can't maintain/support], giving a fish instead of teaching to fish, etc) seem to just not apply.