I have been worked for a regional ISP 10 years ago and having an architecture like that one, would be a godsend.
With centralized BNGs we were not able to apply upstream QoS policies for subscribers on the backhaulings and we had to apply policies on DSLAM access ports.
We ended using a couple of cheap Mikrotik as PPPoE concentrators for every access room, in a similar way as you did. But the reliability of Mikrotik routers was not the best