Hacker News Reader

Comment by vconnor | Hacker News Reader

  public static final String DISALLOW_FUN

The default value is false. [...] Type: Boolean [...] Constant Value: "no_fun"

Source: https://developer.android.com/reference/android/os/UserManag...

---

How the hell did this pass code review? Are booleans strings on Android?

View on HN

> How the hell did this pass code review? Are booleans strings on Android?

You are misreading the documentation, it's a key/value API.

`DISALLOW_FUN` is the string key you pass to `setUserRestriction`, which takes a boolean value.

That makes more sense. Thanks.

Also this is an enterprise policy constant, so it gets sent (and configured) as string/string dictionary via REST API from MDM backend. That's mostly because the constants can be of mixed types (e.g. "MAX_PASSWORD_CHARS" : "1", "DISALLOW_NETWORK_SWITCHING: "true" - example, constants not actual).

Someone else pointed out the reason for the datatype. A more subtle problem is the use of double negatives. Boolean APIs like "disable" will throw off users of your API.

Reply on news.ycombinator.com