Hacker News Reader

Comment by dorian-graph | Hacker News Reader

Like the author, I'd appreciate a stacked PRs approach, integrated with GitHub (unfortunately). E.g. `a → b → c → d` where I have PRs open for `b`, `c` and not yet on `d`, that are "linked" to the jj changes. So 1 change per PR or it could even be multiple. I've lately become a huge fan of git-spice, that just works.

View on HN

Stacked PRs is clearly a nice workflow... except that forges like Github generally have really poor support for them.

I wish Github would just allow you to say "this PR depends on this other PR", and then it wouldn't show commits from the other PR when reviewing the stacked PR.

But as far as I know you can't do that.

If you change the target branch it will only show commits that are against that. I wish GitHub did that automatically because it has the parent commit tree but when do you that you'll only see commits that diverge from the target branch/pr.

Is that what you want?

That works but depending on how you merge the PR, you end up needing to do a rebase on all of your future PRs.

I really wish 1PR = 1 commit with revision based diffs. Similar to gerrit.

Not really. I've tried that with Gitlab, but it's kind of awkward. My PR isn't to merge branch B into branch A. For instance if the project owners see the PR for B and say "yeah great! I'll merge this" and press merge, it will just merge it into branch A and then close your PR!

It's a hacky workaround at best. I want proper support. I want Github to disable the merge button until the dependencies are merged. I want it to actually list the dependencies and link to them. I want the target branch to be `main`.

I think if they did those 3 things it would go 90% of the way. Too much to ask though clearly.

Another person has commented that you can do this, but it's a little known thing. git-spice automatically manages it for you too.

It also doesn't work from forks.

This has annoyed me a few times, just recently a week ago. Thanks GitHub.

Graphite.dev does this, and it works great.

Reply on news.ycombinator.com