Unlike what "The Big Short" would have you believe, there are lots of people who saw 2008 coming. The American property market bubble was on the cover of the Economist many times in the decade prior to 2008.
However, the collapse came a lot later than many people expected, so many people who correctly shorted the market got burned via coverage calls before the market collapsed.