In a world where Kevin Rose can reboot Digg, Nate has every chance of acquiring and reviving 538. Good luck to Nate.
I never really followed the "Nate Silver" controversy after 2016, but it basically seems to boil down to a bunch of liberals being mad because they felt lied to for no apparent reason.
FWIW I don't think he's controversial because of the 2016 polling miss, most people who follow 538 understand what 538 does and that it wasn't his "fault." He's controversial because he posts scalding hot takes on Twitter and then goes to the mat to defend them. He also has a penchant for getting into Twitter beefs with other big names in his industry.
I think, actually, he needed to sell content and resorted to ragebait for attention; the transition happened when he and Disney parted ways, and he stopped being a creator sponsored by a media corporation and started being an independent content seller.