Don't Be the Asshat: A Maintainer's Perspective on Code Change Reviews

andrew.grahamyooll.com

4 pointsyuppiepuppie4 comments

Any engineering manager or team leader that does not actively look for this is not qualified for that position. It’s bullying. The teacher has to step in. The thing this post is describing is something I’ve witnessed in at least two companies.

Often times the perpetrator is a high performer who is given this latitude.

Not sure I follow. Are you referring to the contributors behaviour as bullying? If so, I would agree to a certain extent. Although its not the typical kind that one would come across.

Yes, the asshat is a bully. I have to be transparent and express that I have been an asshat as well, but hurt people hurt people (it is absolutely not an excuse). You have to recognize it.

All sins are done together, but I’ll try not to use such language as its inflammatory. We make the mistakes together, and we have to fix them together.

Right, and not everyone is perfect :) . As a manager myself, I find it difficult to background check (if you will) potential hires for this. 90% + of candidates have never contributed to an open source project to the extent of creating a PR.

Reply on news.ycombinator.com