Yes, that work for you on your current system. But using a icns file as the source for setting an icon, the icon (quality) can scale across devices & system versions.
So ultimately it’s more of creating an actual portable icon file.
https://en.m.wikipedia.org/wiki/Apple_Icon_Image_format