Comparing estimated vs actual survival suffers from hindsight bias in the same way that you alluded.

Though it's still well known that doctors overestimate survival. Which is why they use tools like Palliative Performance Scale [1] to address this.

[1] https://www.mypcnow.org/wp-content/uploads/2019/02/e37642_38...