Couldn't explain the problem to him... I just learned to read through full review from him first before starting to address anything. Otherwise he was one of the best people I worked with and the feedback was valuable.
Couldn't explain the problem to him... I just learned to read through full review from him first before starting to address anything. Otherwise he was one of the best people I worked with and the feedback was valuable.
> This whole thing won't work because of X and you need to pretty much rewrite all of this.
>
> Rename foo to bar.
> Typo.
> Missing whitespace.
So yeah... Just don't post the rest? I often go back to earlier comment drafts and edit / delete them when I realize deeper into the review they are no longer relevant. The review comments should not be a stream of consciousness but properly written feedback.My advice would be to not take it so personally and assume good intentions from your reviewers.
If someone gave me feedback that caused a big course correction then I’d slap my forehead for missing it, thank them, then move on with my life. The extra feedback of other issues is a bonus. Asking them to spend more time reviewing their review is wasted effort.
Yes.
> Often it's the expressing opinion part that's more important than the actual nits.
Your opinions are not that valuable. Focus on the most valuable feedback you can give first.
Otherwise you'd have a "bombshell" to refactoring, then on the 2nd review pass a handful of nitpicks that you could have addressed during the initial refactor.
Promoting leaving notes as you go, for him only to find it later, with no way in the tool to reprioritize?