Hacker News Reader

And what is the right fix? Does it recommend std::move with push_back or does it use emplace?

The one from clang-tidy the author mentions.

I personally consider that to be a bad recommendation and my understanding is that the author also objects to it. I would bet most people are unaware of how emplace actually works and for a reviewer it's more cognitive overhead too.

> I would bet most people are unaware of how emplace actually works and for a reviewer it's more cognitive overhead too.

If you are doing professional development in C++ you should learn the difference and how to recognize incorrect usages

I'm unconvinced. emplace is inherently more complex and requires a complete understanding of the relevant constructors of the value type in the collection. push_back is much less surprising.

I'm not a professional C++ developer, but I'm obviously required to use the language every once in a while and I vastly prefer code that requires me to have to look at fewer implementations of potentially implicit and hidden things.

std::make_unique does the exact same kind of forwarding arguments to a constructor. Yeah it's important to know which constructor you're calling, but that's just a general fact, emplace_back isn't exceptional.

Reply on news.ycombinator.com