I'm guessing I've done 6 in-place upgrades over the last decade and have yet to have one fail.

It sounds like maybe you've had issues but the process does typically work.