I don’t think any of that is contradicted by what this seems to be trying to do. In fact, Go doesn’t make you deal with your errors (you’re free to ignore the returns) whereas this would (via exhaustive pattern match).
Your right, it does not. I will _ =: an error in a throw away script all the time.
I see that in a code review, in production code... Big red flag. This is a departure from an exception, that might be thrown in one place and handled far far away from the code you're looking at.
[0]: https://github.com/semilin/genkey/commit/fafed6744555c5a81fd...
EDIT: The fact that this was a bug at all makes me fear for the rest of the code base. If this one slipped through the cracks, how can I know that the rest of the code base is correct?
The fact that the commit was accepted into a release without any changes to accompanying tests is what is most concerning. You should be afraid.
Generally getting zero value from a map is a feature, but the code that the diff replaces did look overly complex and fragile to me already tbh
You can ignore errors in Rust.
Which is a flaw in Borgo, at least when interfacing with Go code, as in Go both T and E should independently valid states.
on error goto next