Of course nothing can be complete, but I had the following pieces of feedback (plan on opening a GitHub issue later):
The compiler flags section is missing the following:
* Os - optimize for size
* LTO
* Compiling -ffunction-section -fdata-sections & then linking with —-gc-sections (arguably this one just reduces the size of the binary through dead code elimination)
Other:
PGO should probably be mentioned in the flags and targets section as “we’ll describe this in situational optimizations“ (not sure why it’s written there but whatever).
AutoFDO isn’t discussed which is important since it makes running FDO actually feasible in production.
Cold annotations and hot/cold code splitting (hot/cold code splitting isn’t even discussed).