Maybe not bad advice, just ineffective in any mature industry where promotions are typically internal, changing jobs will almost never land you into a more senior position - unless you are really, really good at CV stuffing and bullshiting your way through interviews - and leaving will usually "reset the clock" you accrued on the internal promotion ledger.
It this, more traditional setting, promotions are a power game and managers use promotions strategically to increase their own power in the company and gain allies. This means that you have a cooperation-competition relationship with your own manager: he either levels up and drags you too because he wants loyal people around, or he sees you as a potential competitor his own boss might promote into lateral teams that will then suck his resources. Knowing where you find yourself in this game, who are your allies, what does upper management want and how can you fulfill it and gain their confidence are the keys.