Using the above methodology, I ran numbers for a desalination factobattery and it's really bad, like two orders of magnitude more expensive than just buying a Li battery to buffer the unreliable energy and running desal 24/7.
Thanks for educating me!
Also, the concentrated brine is a real problem in any area that has regular sealife. Maybe not a big problem in the salt ponds already, but it will kill off anything normal.
Amortized capital costs for desalination runs about 40%,[0] so if you "charge" for 12 hours and "discharge" for 12 hours then your facility doubles in size, so your desalination cost increase by (at least) 40%. This doesn't even account for added maintenance btw.
If you charge for 6 hours (ie the solar peak) and discharge for 18 hours, you need a facility 4x as large, and your desalination costs increase by at least 160%.
Desalination isn't 'free' energy storage.
[0] https://www.advisian.com/en/global-perspectives/the-cost-of-...