We normally use ordinary least squares when we do the linear modelling. Maybe they are and I can’t read the Julia code.
Also they aren’t adjusting their closing prices do dividends as far as I can tell.
Nor are they taking dividends payments into account at all as far as I can tell.
They did get the shift from daily to hourly right when they went to their crypto example so good for them. They are ahead of most day traders there:)
Also no work in the hurst exponent to figure out the reversion time frame
Also no modelling on how each pair will fit into your portfolio composition and if you can get borrow, which you certainly can in this instance, and trading fees.
Also they skip regime detection, which is determining what regime the market in general is.
Lots of pairs only work in up or down or sideways markets and you’d want a different ratio for each. And you’d want Tom look at how your pairs works in each market regime. I find this to be the most important piece and. You never seen pairs tutorials take this into account.
Probably because you his is the hard piece that makes you money.
This is why pairs are thought to trade. This link is the star arg 101 tutorial that is in 50 different places in the internet but it doesn’t show any of the actual meaningful work you need to do to trade pairs.
Other missing pieces are leg sizing, how long you let a leg hang, how many legs do you out out, portfolio composition, dynamic hedge ratio calculation,market regime detection.
It shows the easy piece that you can code up in an afternoon.
And now I feel like I’ve shit all over this poor kids project. It’s well done and covers the 101 issues with a few pretty large missing pieces that I’ve pointed out