Hacker News Reader

I hope these guys aren’t trying to suggest that hard-coding the specific css-animation logic into the "show" function of a generic "page" view is generally good practice when building some complex app.

It's fine for a quick demo, but that’s definitely not where such logic belongs for any kind of maintainable project.

View on HN

I've heard anecdotally that setting those css animations via JavaScript vs defining them in a stylesheet, then toggling classes in the code, yields slightly better performance. I have nothing to back that up but would be interested in hearing if other's have noticed the same thing.

css transitions are now typically hardware accelerated, so yes, I'm guessing they would be more performant (especially on mobile).

To clarify: I don’t have a problem with triggering animations from JS directly. I just have a problem with hard-coding several blobs of unexplained magic css directly into an unrelated function, instead of building a general-purpose animation framework, and calling it by some clear and readable API. As soon as you want to tweak the effect, in this version, you’re in for a pile of trouble. Or if you want to use the same effect on a different view, you’re left copy/pasting. It’s the kind of unplanned code placement that works okay for a demo but quickly falls apart when requirements change or the project grows.

Reply on news.ycombinator.com