A friend of mine felt it was finger-pointing when her coworker said "could you take a look at your commit `abc0123`? because it broke the test `Xyz`". When I saw the screenshot I thought it was direct but professional.
My opinion was dismissed because "yeah you think so because you're a bit socially awkward too"
But I agree with the rest of your take.
IMO, it was appropriately finger pointing. The person who breaks the build should be the one to fix it - they're the one with the most context.
But also - require tests to pass before a commit is allowed. It makes development so much better.
Agreed.
I did not dig for the deeper context, their org is probably quite dysfunctional.
"Hey, I think commit abc0123 might have broken the build, and it looks like it was yours (link to build results). Would you mind looking at it?"
I give myself a little room for being wrong (sometimes I am), and it comes across as being less of an ass, to which people generally respond positively.
Or if you just have the (good) habit of checking in your work in progress code frequently, or daily.
Or if you have several workstations you want to share code on.
Point is that commits should be frequent and requiring tests to pass before you can commit is guaranteed to make sure that commits are infrequent.
I prefer to put "tests must pass before PR can be merged", rather than before commits can be made.
It solves all of those issues.
I worded it poorly, but this is largely what I meant. Although I was trying to stick to commits on main/master for the repository of record since PRs are a github (and bitbucket?) thing, whereas pre-commit hooks are a git thing.
I think you're fortunate to have someone be able to tell you stuff like that without it offending you [2]. Maybe she needed to vent a little. It's nice to have someone to vent to (within limits).
In a week or so she might come around and agree, yeah we shouldn't break the build--but at the time it was annoying to be told that (due to tone or whatever reason).
Surely, they knew you were socially awkward before they asked.
But if you find that important, my opinion was unsolicited. She ranted about the coworker in a fb story. I found that unfair and shot her a message.
That's not just unfair, that's horribly unprofessional.
But your friend should also have less of an ego about it and accept responsibility.
That being said, I've been in team environments where the language felt personal and like I was being thrown under the bus unnecessarily. So I've been on both sides.