>I don't know where you learned shell scripting, but your formatting is very confusing

i don't know where you learned English composition, but I can't follow your critique. are you pointing out your preferences (which may well match gnu or bsd standards, i don't know tell me) or things that actually make a difference? Did he break emacs auto-indent? Are you pointing out all the flaws or the correct ways, i'm having to eyeball diff. Use more of your words.

    while
    do

doesn't seem substantially worse/confusing compared to while;do unless you have some reason?

spacing out ;; does it make a difference? or do you like things spaced out?

etc.