Sometimes diffs are bad (I would bet github uses diff -ow, or something similar) and in general PRs are a drag.
Typing out 85 review comments and having them swallowed by a 500 response because the frontend thought that of course XHRs are always 200 OK, why wouldn't they be? is indescribably infuriating
If I had more energy, I'd try that on some big MR to just to find out whether their stupid extension also just assumes all XHRs are 200 OK. That'd be some icing on the cake
1. POST /review/temp
1. POST /review/temp
# all done, submit the batch
1. POST /review/submit <- 500 Oops we sorrwweee
# now every comment is gone
I don't recall this second whether the actual sequence is "POST" followed by "DELETE /review/temp" meaning this is 100% a JS bug or whether it's "POST" and the controller for submit nukes the temp version, making it a ruby bugAnd yes, "extremely pissed" isn't strong enough but ... put it on the list of the other 48,000 issues, I guess
Did you notice Github's improvements to "projects" over the past couple years?
I feel like they missed doing a big announcement, cause it was like gradually implemented as a "beta" and then slowly filled in. But it's much better kanban now. Might still not be as good as gitlab's, I couldn't say.