What's wrong about it?

It seems to get the result I want, but not sure if I'm missing something.