One thing I don't get, why they call themselves "WebKit reviewer", they've made tons of contributions (of high value) to WebKit, way beyond what I would think a "reviewer" would do.
One thing I don't get, why they call themselves "WebKit reviewer", they've made tons of contributions (of high value) to WebKit, way beyond what I would think a "reviewer" would do.
> A potential Reviewer may be nominated once they have submitted a minimum of 80 good patches. […] A person who submits many patches but does not show good collaboration skills, code understanding or understanding of project policies may never be nominated.
And when someone becomes a WebKit Reviewer, their status is announced publicly under a special tag[2]. My interpretation (I’m happy to be corrected if mistaken) is that this status is essentially maintainer, but perhaps outside the team at Apple.
1: https://webkit.org/commit-and-review-policy/#criteria-for-re...
Similarly Apple employees have to go through the same nomination process to become reviewers, and are subject to the same requirements.
Basically: how can you be an effective reviewer if you aren’t able to write the code as well?
I’m unsure of any project that has otherwise uninvolved folk who are reviewers, and can’t imagine where that would make sense?