>"At the end of the day, VS Code is a shitty Electron app. "
It provides huge practical value to me as a developer. I am not fond of JavaScript being used as front end but as long as it performs decent job for particular use case I do not care. I use development tools to develop products and make money. I do not fight holy tech wars.
>"Startup time on my machine is only a hair faster than Jetbrains IDE's launching a JVM, it's ridiculous."
I value my development time and my development computers are very decent (desktop for example is 16 core AMD with 128GB RAM). Launching VS code on my machines is nearly instant. CLion from JetBrains is much slower (10 sec from cold start to opening my C++ project in a usable state for example) but still very acceptable. I do not restart it every minute. More like once in few days when using it.
>"VS Code has the market share that it has because:"
I do not care why. I am a consumer here. It is for a people who want to beat VS Code to figure out why and do better than MS. Me - I have my own problems to worry about and I just use tools that work for me.
>"Most importantly of all (in my cynical opinion), they went "dark mode" by default at just the right time when this was becoming a trendy new feature among devs."
I do not give a flying fuck about what is trendy for a generic developer. What is important for me in VS code along with plugin ecosystem let's me develop, lint, debug my code locally and on remote servers. As long as proper ergonomics / usability guidelines are followed I do not really care whether the mode is dark or light.
>"If someone came out with a free, cross-platform, attractive text editor that was a native executable and got critical mass going with a plugin ecosystem, then VS Code would fall out of fashion within a year."
And if I had a million dollars I'd be rich. Coulda, shoulda, woulda. And VS code is way more than an editor.
>"No one wants to create desktop apps anymore".
I actually have native desktop product and it keeps bringing me some dosh for what is a very little maintenance.