OK, let's go by your definition:
"being less suicidal is a definition of happy"Preface: I believe gender dysphoria is real suffering.
From the paper: [1]
Have You Ever Had [Pubertal Suppression] for Your Gender Identity or Gender Transition?
Yes, n=89, of which reported suicidal ideation in the last 12 months: 45 (50.6%)
No, n=3405, of which reported suicidal ideation in the last 12 months: 2204 (64.8%)
The paper [1] concludes "Among transgender adults in the United States who have wanted pubertal suppression, access to this treatment is associated with lower odds of lifetime suicidal ideation. This study strengthens recommendations by the Endocrine Society and WPATH for this treatment to be made available for transgender adolescents who want it."
I think the only conclusion we can make, is that we have some sick puppies on our hands, and they need our love and compassion. I do not the data gives us cause for celebration. I do not think the data makes a strong connection between hormonal treatment of children and long-term positive outcomes. I understand there is a chicken and egg problem here.
[1]https://publications.aap.org/pediatrics/article/145/2/e20191...?