Tesla engineers were on-site to evaluate the Twitter staff’s code, workers said
washingtonpost.com
washingtonpost.com
There may be some three line change that was the result of eight hours of debugging and analyzing how to best fix the bug without disturbing the stuff that is working. Is that more or less productive than someone who cut & pasted a 100 line routine they found via google?
On a different note, If you're in a large org and all you are doing is fixing bugs, you are doing yourself a disservice and so is the org in the way they are treating you. Unless you are the original author of that code. When people don't fix their own bugs, they tend to repeat it in other places. When people tend to fix code they didn't write nor have the proper context on why the code was written like that, they tend to turn it into a mess. IMHO, Developers should be writing new code and maintaining their own code. Never reward developers by giving them more new code and stopping them from maintenance.
... but in practice, I think you will find 0 overlap in raw lines of code produced between the top 10% developers and the bottom 10% developers. Especially at a notoriously unproductive organization like Twitter, the bottom tier simply does nothing.
If Musk is trying to cut 60% of the org, he's going to have a problem doing it this way. If he's trying to cut 20%, I honestly don't think it's going to misfire much of the time.
https://www.smithsonianmag.com/history/charles-proteus-stein...
It’s really hard for me to imagine myself working at a company that deals almost exclusively with machine-generated data (as Tesla does) and being assigned to judge a social platform’s engineering qualify in one day. Cars and spaceships on a closed network are fundamentally “clean” compared to having hundreds of millions of people who produce dirty and often adversarial data.
But I guess the point of this exercise isn’t really to judge code quality, but to drive fear at Twitter.
“Code” is most likely “architecture” and “architecture” is code for “management”.
Auditing what you just bought is about as smart as taking the used car you just bought to the shop to get everything checked over and tightened and lubricated.
Ooh they use tabs here rather than spaces! And that experimental code over there contains an unused variable! This A/B testing pipeline has minimal test cases! They ship in a day without a Q/A pipeline.
All of the above would happen if any company were acquired by any other. The code style will be different, and the dev practices will be different. Companies optimized to ship quickly will appear low quality to those who optimize for quality, optimizing for quality will appear as a slow moving dinosaur to those who move fast.
There are legitimate questions regarding how certain sections of the Twitter code operate as it relates to censorship, which is a primary reason Elon purchased Twitter. Given the activist mentality (and possibly hostile to new ownership) of a certain number of developers, it seems perhaps prudent to analyze the code and evaluate the existing developers immediately upon purchase of the company.
I don't agree that it's to drive feat at Twitter, as just about any engineer will know what I just said. What I think it's about is driving the headlines, "Tesla engineers are doing a code review at twitter" sounds very important to the lay person.
California is at-will, but notoriously anal regarding mass-layoffs. My serious question is, regardless of with or without cause, surely some employment attorneys are licking their lips at the stack of prospective cases they're about to have, right?
If I was a Twitter engineer, I'd be trying to figure out how to maximize my severance package right about now.
Absolutely. This is how I would spend every minute of my workdays until the eventual layoff. It’s a degrading experience for sure, but it could pay off big.
How would one go about doing that? Is there a way to have influence on that?
Passively destroying Twitter from within by not trying, and trying to make a billionare lose 44 billion dollars is a significantly more fun and interesting challenge than making Twitter a better product.
If I were a engineer at Twitter, I'd do my absolute best up to the minute I have to leave the premises. Because I would care about the company, my colleagues and most importantly for the >200m people who use Twitter for fun, educational, business and those who depend on it.
But it's probably because I'm an old beard, who value being honest and ethical, to be the better person even if I'm in a room of degenerates.
There's so many "What we should do" moments that are too expensive or deviate too far from the core business that don't get developed in most enterprises that could be pursued when starting from a blank slate.
Anyway, just a thought experiment.
A code review? TL;DR; LGTM, straight to prod!
It’s not worth staying at a company that gets acquired, you’ll either get laid off or be asked to do the same work with less people, and awful morale.
I wouldn't be quick to dismiss the idea that this is a show.
Imagine if Elon bought an airline and asked them to line up all the planes on the tarmac for review.
This was a change in ownership, not an acquisition. There's an assumption about a lot of dead weight at Twitter. There certainly may be, but it's not simple redundancies (ie, you don't need 2 accounting depts.). Instead they'll have to figure out if Twitter really needs that many people.
My guess is Twitter isn't as over-staffed as people think. Content moderation and multi-country policy likely require a lot of staff. To quote Scott Galloway on his attempted company take overs, "I often find out I'm not as smart as I thought I was, and the existing management isn't as dumb as I thought they were."
Yes you can, it's called an audit and there is nothing wrong with that. The company you work for should have regular security audits for instance, ideally done by a third party rather than internally to eliminate bias. This isn't a "code review".
A quick interview and a little demonstration of contribution can help assess these things significantly, you don't have to understand the codebase that much to do it.
Social networks don't have a particularly long life expectancy.
Anyone know the articles / blog posts I’m talking about?
FWIW, I don’t think the idea of Elon having his own folks do some internal reviews egregious. Id bet the comm and positioning around it was suboptimal though, atleast given Elon’s personality.
SpaceX has had a somewhat similar reputation (at least early, it may have changed for the better).
For example, they had a spectacular failure related to bad material quality in a strut.[1] It's common practice in aerospace quality to have "coupons" kept, tested, and traceable for these types of critical components. Apparently, SpaceX wasn't follow this procedure and they changed their policies after the mishap to do so. There have been some other deviations from standard practices that may lead one to raise an eyebrow.
I've sometimes wondered if these are examples of an attitude of "move fast and break things" creeping into other (generally more conservative) safety critical domains.
[1]
For balance, there have been bugs - the linking of key fobs to driver profiles has always been glitchy, and Tesla’s decision to use an inadequate eMMC chip was shortsighted given the volume of data logging. This caused issues for a few owners when the chips started to degrade over time. But to Tesla’s credit they later offered a free chip upgrade to all owners, and even covered the costs of those (like me) who got a third party replacement.
I rate Tesla’s software engineering. I’ve had years of issue-free OTA updates and sheer pleasure from driving the car. And having access to the car via an API is cool too :-)
There is literally no good reason to do that. At best it is staggering incompetence. At worst it is an intentionally pointless and expensive exercise that serves purely as a loyalty test.
My take on the paper printing is that it is a similar strategy to get people to quit by themselves, because they think it's stupid.
The engineers would have used company's resources. I wouldn't be bothered if I am forced to do this. It is a 1 minute of work to print something.
I don't think this part is true. It is likely fake. The source for the print out story is so shaky. Leah Culver tweeted obscurely which is hard to tell whether it is a joke. Casey claims to have screenshots but refuse to show the redacted version of them and end with "subscribe to read"....
The code review part might be true but it is not a spicy story.
It's truly bizarre.
Or maybe this was to set the expectation that only those who care enough to bend to the whimsies of the new management should stay?
Or both?
Paper the UX is perfect and instant.
Or simply Elon is more unstable than Dogecoin and wanted to show new employees who is the boss, it was a really pathetic power move.
That place is full of folks who are truly of a "rest and vest" mindset. They are also very political (left leaning) and biased. Which really affects moderation and the so called "open" culture. That "open" propaganda they push on their career website is really based on incrowd psychology.
There are a few gems but the really good ones left already. Now it's just the last leafs waiting to fall off the trees which are still standing. The bird has been resting and vesting on leafless trees for a long time. I would be weary hiring a developer from there knowing their record.
It's full of people trying to justify their roles to themselves and their peers with unecessary rewrite schemes for a long time.
The bird needed to migrate for a long time. I am happy it has finally sought a better climate.
However winter is coming.
You are simply paraphrasing exploitation.
>but if you see most of his businesses, his expertise is dealing with governments, contracts and policies makers
Looks more like brute force and public shaming to me.
I can see people working themselves to the bone after buying into the missions of SpaceX and Tesla ("fuck yeah, space!" and "AI-powered electric cars saving the world" respectively) - but not for Twitter. Musk may find himself with less eager employees than he's used to. If he cuts too deep, I suspect Twitter will enter a downward spiral on talent.
Mike is his handler for SpaceX, https://en.m.wikipedia.org/wiki/Michael_D._Griffin#Career
Really? I thought opposite. Tesla growth was helped a lot by EV subsidy. SpeceX was made thanks to space industry privatization, and get launching tasks from govt. Boring Company is something like for public transport infrastructure.
The autopilot team didn’t like being quizzed on basic c/c++ questions and that was the first time almost all of AutoPilot quit.
Or so I heard.
Airline pilots don’t quit in a huff because they have to demonstrate basic competency annually.
Probably I will get tons of downvotes, but there is this strange myth here (and on reddit) that there are no incompetent programmers.
When in reality there are tons of incompetent programmers, just like there are incompetent people in any other job.
not unproblematic by a long shot, but quick, and probably somewhat effective. and it wouldn't require any deep knowledge of twitter's codebase on the part of the reviewers.
Printing it out as a mark of honor/shame is something a petty, arrogant tyrant would do. Musk has been around people who are afraid to say no to him for too long.
https://www.oreilly.com/library/view/designing-data-intensiv...
Just guessing, you'd think Starlink would be more experienced in that area than either Tesla or SpaceX? I suppose there are things like remote software updates and internal working databases to manage at SpaceX and Tesla, but it seems managing satellite traffic is a closer match.
Who knows, they might be, I really don't trust WaPo reporting anymore.
What makes Manhattan special (Twitters internal database) isn't it's scale (FB, Google, etc operate DBs which much higher scale) but it's multi-engine paradigm and other cool features.
The Tesla folk that are there probably aren't even DB specialists though, they are likely just there to evaluate the lay of the land and start the process of working out which teams are pulling their weight and which aren't.
(and let's be honest, Twitter hasn't solved the concurrency issues, so I'm not sure there's much to review)
> The note continues, “Please come prepared with code as a backup to review on your own machines with Elon.”
It seems to me that some engineers are being evaluated for their suitability to being in those positions.
Maybe it's an engineer review, not a code review.
Reminiscent of the Elon message to the former CEO: "What have you got done this week?"
And then just hope it isn't quid pro quo sexual harassment.
Elon makes his equity-compensated employees rich. You don't need complex psychology to explain the appeal.
Steve Jobs, Larry Ellison, Bill Gates etc. were all a nightmare to work when they were younger.
From what I can make out Twitter's workforce are predominantly average at best and I suspect we'll see at least 2,000 or so people cut in the next 6 months.
[1] https://twitter.com/swyx/status/1513301310434529288?s=20&t=Q...
Using Tesla engineers is just to get everyone talking. I don't think they can get a clear picture by looking at last 30 days of code but they can use this as reason to lay a lot of people off. Not that Musk needs reasons, obviously.
In my mind I think Twitter is going to go on a very, very different direction than we all expect. You have to understand that Musk isn't after the big dollar here but rather he is experimenting which has a lot of chances to fail. Twitter could become extraordinary or it could become utter trash, we'll have to wait and see. Personally, I am quite excited to see where this goes.
Musk didn't know the bio of the CEO of the company he was buying (who was also former CTO, engineer, Stanford PhD (thesis topic: making decisions under uncertainty), IPhO gold medalist, top tier Indian tech student) and called him a non-technical "manager type" and refused to ask him any technical questions.
I am also excited, because I think Twitter needs to end and Musk is the perfect person to destroy it.
I think there's a simpler explanation: he intends to fire people under the pretext of poor performance and play games with layoffs/severance and/or create a hostile environment to encourage employees to resign (no severance either).
> You have to understand that Musk isn't after the big dollar here but rather he is experimenting which has a lot of chances to fail
Musk wanted out of this purchase, but discovered the Delaware Court of Chancery far less malleable compared to other regulators he's dealt with before (looking at you, SEC). Tesla is going to be a learning experience for Elon.
I can very quickly spot developers who are mediocre or worse by looking at their last 30 days off code. (As long as it's a language I have decent experience in.)
I suspect he's trying to access the team's technical competence.
I would view it as a way for Tesla engineers getting paid to go to a software conference. It is definitely possible to learn something during the code review to take back to Tesla.
- new materials from SpaceX make it into Tesla cars
- productions techniques from Tesla goes into SpaceX rockets
- Semiconductor teams from Starlink probably connected to Tesla
It mean the best engineers get even more opportunities. win-win
Less red tape, more work get done. I think we should all embrace that.
Our goal should be to make things better first and then to make money second to help us out make things even better at larger scale.
To me it makes a lot of sense. I doubt they are reviewing the entire code base. It seems like Elon is particularly interested in the automated systems that control content and detect bots. To that end, Tesla has a lot of expertise in AI systems.
This is a tiny amount of money compared to the daily cost of running TSLA and would have zero actual impact to shareholder value. If it isn’t being accounted for correctly, there will be a tiny investor lawsuit and a tiny amount of money changing hands.
This is latching on to just anything to complain about and really detracts from the ability of elon critics to be taken seriously because it’s just complaining about a few pennies worth of shareholder value.
Maybe they're Tesla engineers, but they're moonlighting on Twitters dime?
> The arrangement alarmed some longtime investors in SpaceX, including its largest outside backer, Peter Thiel’s Founders Fund, some of the people said. The investors learned in recent months that despite the diversion of SpaceX resources and staffing to the fledgling Boring startup, it was Musk who was in line to receive almost all of any future profits, these people said.
https://www.marketwatch.com/story/new-questions-over-elon-mu...
> In early 2018, The Boring Company was spun out from SpaceX and into a separate corporate entity.[27] Somewhat less than 10% of equity was given to early employees, and over 90% to Elon Musk. Subsequent concerns by SpaceX shareholders resulted in a December 2018 reallocation of 6% of The Boring Company's equity to SpaceX.
https://en.wikipedia.org/wiki/The_Boring_Company#History
Basically he tried embezzlement.
Been there, done that.
Would you be angry if he gave everyone a 2 week vacation as recognition for doing something good? Part of what motivates engineers is recognition, and being asked to work on some project outside the company for a few weeks is recognizing that your input as an engineer is that valued.
Eh, there are marketing synergies between Twitter and Tesla.
Seems like a drop of water. For something to be legally relevant it has to be significant.
Remember SolarCity? SolarCity was one of Elon's companies. SpaceX had bought a large number of solar bonds. One interpretation of this was to keep the company afloat. A court disagreed [1]. When SolarCity became insolvent it was bought out by Tesla.
So one of Elon's companies bought out another of Elon's companies to save the third Elon company.
There is this myth that exists of Elon being some kind of tech deity but there's a much better case to be made that he's simply a highly privileged technocrat who has quite successfully failed upwards his entire career [2].
[1]: https://www.cnbc.com/2022/04/27/elon-musk-wins-shareholder-l...
[2]: https://www.marketwatch.com/story/the-many-failures-of-elon-...
For sure a software engineer from Tesla, or even a manager, can get an idea of how valuable/productive a coder is without fully understanding the code in detail. How many PRs? What does the code do? How was it reviewed? What value does it bring to stakeholders (users, business revenue)? Sure enough this way you can get a rough idea of how much work somebody does and if it is of any importance.
The loyalty part is in the timing: 30-60 days. A period with a lot of uncertainty for Twitter employees. The Musk takeover in the air but even if that would not follow through, there were already severe job cuts in the pipeline by Twitter's board.
If under those conditions you kept your head down and kept coding like a stoic, then you're a keeper.
The most valuable engineers to me are the ones that can bring a thoughtful, elegant, well-implemented solution to a business problem. And typically that doesn't translate to lots of PRs, often is not appreciable from non-engineers and can not be easily judged in a few days. But their work almost always stands the test of time.
Before hiring/firing people it would seem prudent to me to at least spend some time getting to know the dynamics in the team, the challenges facing them and then evaluate who deserves to be there or not. I really don't understand what the big rush is here.
I think most are missing that this is a code review + loyalty review.
I think most people realize that it's more than a code review, in fact I suspect that it's such a transparent loyalty review is exactly why so many people's feathers got ruffled. For sure a software engineer from Tesla, or even a manager, can get an idea of
how valuable/productive a coder is without fully understanding the code in
detail.
Yeah, maybe. But Musk is asking SWEs to print 50 pages of their code so he can personally can review it. Any halfway competent manager or exec should be able to see this is not a good way of reviewing performance in earnest.For a junior engineer sure this is probably a reasonable gauge of your productivity. As you become more and more senior number of PRs and LOCs becomes a worse and worse measurement. This is basic software engineeting.
> What does the code do? How was it reviewed? What value does it bring to the stakeholders
These things are impossible to accurately assess without a lot of context. Context which outside engineers are entirely lacking.
If the accounts of what Musk is doing are an accurate reflection of his leadership -- and based on accounts we have heard from Tesla and Space X in the past it sounds like they are -- he is a terrible leader and his companies are successful despite that deficiency.
Can anyone verify this story?
Galileo’s interview at SpaceX shows his thinking and way of working quite well.
Teslas are probably better than the vast majority of car companies, particularly the UI of the touch controls and system, but it still seems weird to me to have engineers from a company perform a review in an area that they aren't known for. Honestly, I would assume Twitter has better software engineers.
They're a "trusted" external party that Elon can use to get an unbiased assessment of what's going on internally at twitter and get a better picture of what's valuable and what's not. If you ask a senior engineer at Twitter the same questions you'll get a very different set of answers, not necessarily wrong answers but a different perspective. Unless Elon's an idiot he'll be doing both.
The client then hired an American .NET shop to recode their flailing PHP code to feel trust and safety with respect to their products offering.
Let's just say I am not surprised at this code check. It is the right thing to do, especially with Twitters performance. They all just got complacent. Happens to all the big and stuffy companies.
Meta also needs a shake up. Bezos should come out of retirement and take the helm from that child who is running it now. Before he sinks the total ship.
This shouldn’t be the exception, it should be the norm.
I can always tell which company sells products the CEO doesn’t use and has likely never even seen.
Can anyone verify this story?
we already have "Pranksters posing as laid-off Twitter employees trick media outlets: ‘Rahul Ligma’"
https://nypost.com/2022/10/28/pranksters-posing-as-laid-off-...
As another pointed out, I would expect Musk's crew to be looking for ways in which TWTR people put their thumbs on the scale to benefit the "correct" viewpoints/ideologies/mindsets over others.
The thing where is 99% of the complexity and you can't redesign in a month is the infrastructure, how data is stored, how the various components communicate together, how everything scales globally, and all the related components. Things like Twitter are not complex for the application (that is trivial to implement) but for what it takes to run that trivial applications with that kind of numbers.
Looking only at the code is stupid, since code is fairly trivial to rewrite, while doing infrastructure changes is something difficult, costly and in some cases even impossible.
unless you scope-down "everything" to the point of triviality, that is ludicrously underestimating the intrinsic complexity of twitter's product surface, and all the plumbing and necessary tools that lie beneath
Laughable that you think 10 people can rewrite all of this in a month. It would take longer to scope out the design docs alone.
[1] https://twitter.com/bhcarpenter/status/1585834343766773761
Is this satire?
These actions only make logical sense if the goal is to make life unpleasant for employees, and get a lot of them to quit.
I think their main problem is they thought their role was thought shaping via sneaky algorithms. I think the main thing Elon should be looking to remove is those that fundamentally do not believe in free speech, since the culture of the company has changed so materially.
That is valuable and is not going away.
I'd be more interested to see the difference between the code and the engineers signaling technical debt in areas via email or chat. No idea how to quantify that though.
I dont see how programmers can audit / evaluate / review the code in what the article seems to me to state it was done / will be done fast.
That's probably what it is, just bc someone who's new to a codebase probably won't figure it out overnight, but the clarity of an IC's explanation could indicate their involvement
Do all developers have equal skill and productivity?
Should developers pulling down FAANG-like salaries be given infinite slack? “Oh I see you’ve only attended meetings and haven’t written a line of code for a month. I’m so glad the company I invested $44B into is paying you $50K a month!”
It’s not uncommon in the wider industry to have to re-apply for your own job.
People fail and aren’t rehired because all too often they weren’t actually that productive.
That could be their own fault, or the organisation’s fault for over hiring.
Either way, they’re dead weight and the only way to profitability is to make them redundant.
It’s tough, but this is what capitalism is all about! Work is not a charity…
Laughable indeed. I suspect they're more valuable judging the skills of the developers because if they were actually evaluating the code that would be the most absurd part of this while affair.
I would have expected they already did that prior to the acquisition.
It seems the acquisition was a blind buy.
FYI, I don't own a Tesla or own their stock or own any stock in Musk owned companies. I don't even follow his twitter account.
The point to accept here is:
He is outstanding in what he's doing. In everything. He is a business man and doing everything for getting the most out of that.
No matter if it's his "who pay for Ukraine/Starlink" -> he didn't get the 20th of millions from the government, but he tried it and in the end getting more funds from others.
Or his "lay of 75 percent" - he try to save some money which Twitter is burning ever since. He tries, with the help of his engineers, to find out whether it's possible to lay of so much and still having the company running..
So, the best would be here to ask why this way and not another? All the guys and gals are knowing what's happening. They are the best what could happen to Musk. So, this will be profitable in 6 weeks.
How many cars did Tesla sell on the day after his investment?
Printing off the code and reviewing code are complete side-shows to construct a narrative in the media. You know, his forte as a full-time twitterer (in between smoking dope, playing computer games, jerking off, and impregnating women with whom he is at the other end of a power gradient).
Then he's going to purge all the disloyal people and people who are doing stuff he's not interested in, so he can lower the payroll and establish political control of the corporate structure. His other forte as Mr Sociopath McMoneybags... (although in fairness he had no chance, when his parents christened him with that name, nominative determinism and all)
I am sure many of us remember some Twitter higher-up claiming Ruby was all they needed only to be let go after they changed the backend to stop using ruby as the back end!
And keep in mind Elon has to answer the US Congress questions about security issues which does in fact require an outside code audit in the first place. It's a good indicator of Elon's true intentions to get a more safe twitter for everyone.
Elon is definitely not a luddite when it comes to code, it seems like a very uncharacteristic request.
It's interesting how much publicity this whole situation is getting. Musk must be loving it.
What could possibly go wrong.
> The “idea of Elon being flanked by his Tesla engineers reviewing Twitter code is laughable,” the person said.
It is laughable, and it's just another signal that Elon has no clue what he's doing. Imagine how farcical the whole thing felt to anyone involved who isn't him.
It seems perfectly reasonable for Elon to bring in some people he knows he can trust to help evaluate how Twitter actually works. I presume he's competent enough to do any necessary i-dotting and t-crossing to make it legal. I don't see anything wrong with printing out code either - IMO sometimes it's a handy way to be able to explore lots of code with complex interactions, since you can have a bunch of pages at once and arrange them however you like.
It's pretty clear to me that there are elements of the elite media-political complex that are terrified of Elon purchasing Twitter because he's not part of their crowd and they won't be able to control him and through him what is and isn't allowed on Twitter. IMO all articles about this should be read with that in mind.
Hello IT? This is Bob from Tesla here. I require full access to audit data and source code per Mr. Musk’s request. You hadn’t heard? That’s because Mr. Musk fired your boss this morning now add my personal email to the system.
Having Tesla engineers over to review Twitter code is definitely that. It’s ridiculous.
https://www.autoevolution.com/news/musk-celebrates-expansion...
This will be awesome.