I really recommend doing the math based on your particular itinerary. I've been to Japan twice, 14 days each time, and, at best, I would have broken even on a JR rail pass based on the traveling did. For longer trips, like Tokyo <-> Sapporo airplanes are both quicker and cheaper.
And it's not like you have to get the pass for all region, there are dozens of types of regional jr passes depending on the region you're visiting. Those are the ones that's of better value when travelling in-region, and covers most touristy places. Personally I'd say tokyo-wide, kaisai, and hokkaido are the ones that's pretty no-brainer when in those regions.
I've been to Japan tens of times for work, family and holiday reasons, and I've never found a use case where the JR pass would have paid off for me. Then again, I tend to fly in and stick with a single region; if you're doing the tourist trail thing where you're going (eg.) Tokyo-Kyoto-Himeji-Hiroshima-Tokyo in a straight line in one week, than sure, it makes sense.