I like to take a couple of photos for my album when I am doing some activity I'd like to remember (say, visiting a place on vacation). It's pretty important to me.
However, I dislike two things
1.) Doing it for every small activity
2.) Broadcasting it on social media
For 1.), I find that I don't really benefit from every walk around town or whatever in my albums. It's more enjoyable to remember significant moments - and there are quite enough I think.
For 2.) I find that to find a good representation of what is happening, I need to alter my behavior. Instead of taking two to five pictures, I need to take videos and hundreds of pictures etc. As others have mentioned, this kills the actual thing. Instead of "I visited place X and did Y", it becomes "I took photos and videos at place X pretending to do Y".
So the sweet spot is in between. I am very happy to have taken some photos - even selfies - in the past, and I wish I would have taken slightly more photos (or better ones, or videos) in the past, before we had such nice phone cameras.
Pictures are great to remember moments. For that, we need enough pictures of these moments - but we also need to have made memories. We need to have experienced the actual thing.
Pictures that go on social media are marketing. They have a different purpose.