> There is also strange code like this loop https://github.com/hashlookup/fleur/blob/4ee2644a850381d928a... that jumped into my eye.

The line below that is worse:

strncpy(bloom_path , argv[optind], 128);

If you pass something >= 128 chars then bloom_path won't be null terminated. In general strncpy should never be used for copying strings.

For expansion on that: https://ramblings.implicit.net/c/2014/05/02/c-functions-that...