Yeah the QR code login is slick, TikTok also uses that.

The only caveat for implementing is that you essentially need to have a mobile app for your site, while SMS/email auth are more universal.