Terror might not be the main issue in Israel these days as it was for example around 2000 but it still happens and the reason it doesn't happen as much is partly due to those efforts. The main issue is that there are still entities in the region openly claiming that they want to destroy the country and turn it into another Arab country, most of the military efforts are against this threat. There is no need to judge it cynically as if we are talking now about the US or some European country going half way across the world to destroy some countries as part of the "war on terror".