In most cases I find `sed -i` to be more convenient than using ed in scripts, but the paradigm is a little different.
It is still much more usable than ed. At least, it makes it easier to debug your script.
For a single edition script (one shell command), yeah, I'd say there is no large difference.