Ask HN: How does your team do code reviews?

3 pointsroflchoppa1 comment

I was wondering what code reviews look like on other teams. I’ve only been in one role and exposed to one workflow that the team uses, how does your team do it?

For our team we do a series of reviews with a lower level engineer, then send it up to our lead engineer to review, at this stage it can go back and fourth several times until something is merged in.

View on HN

Everyone working on a project is expected to chip in and review code, regardless of how junior or senior they are.

Typically, a very junior engineer reviewing code for another junior engineer isn’t sufficient. We may require two sign offs before the code is merged.

Senior+ engineers review critical path code, but not every single code review. This is to create space for others and also ensure others are not merely spectators but actively own what’s going on.

Reply on news.ycombinator.com