I'll sing its praises until the day that I die - but it does have disadvantages in that most applications design their keyboard shortcuts and other inputs around QWERTY users. On macOS I can use the Dvorak-QWERTY Command layout to deal with this in particularly annoying cases, but there's nothing comparable I've found on Windows or Linux and that doesn't help with things like Vi.
Not to mention I frequently find myself having to change layouts back in forth in games. A lot of games published even today have a nasty habit of using the character code instead of the keycode for keybindings, and I've gotten tired of redoing bindings in everything just to avoid pressing Windows+Space to change my layout. Additionally, since my keyboards still have a QWERTY layout of keycaps it makes it challenging when I get prompted to hit "Y" (which doesn't get used for important things usually as it's a stretch for the index finger from the ASDF position) and hit F by mistake since I look for the "Y" keycap on my keyboard - ditto when something prompts me to hit "F" and I hit "U" instead (basically the mappings between Q/' E/. F/U C/J V/K are easy enough as they're used often and are within natural reach, but once it goes outside these I start looking at keycaps and screw up).
Anyway, I'll always highly encourage people to give alternate layouts a try and I'm never going to stop - but I'd say there's nothing wrong with using QWERTY either.
The kind of people (like me) who got into Dvorak at that time would today probably learn something like Colemak DH, although there are many alternatives available nowadays and a big (discord) scene of folks optimizing and designing both their keyboards and the layouts they use on them.
I expect Dvorak will die with people like me, because anyone willing to switch away from Qwerty is probably better served by other alternatives.
The caveat to my perspective is that I don't care where hotkeys are. I minimize mouse use, and with both hands on the keyboard it just doesn't matter very much. I've used emacs and vim with both layouts. My faded recollection with respect to emacs is that it was equivocal, and Dvorak is actually a bit better for vim.
This was in the early 2000s and I had to use a lot of Windows and Remote Desktop, so there were at least several incidents a week in which the keyboard would start making the wrong letters and I had to figure out why. It doesn't help at all that Windows' default layout-switcher switches using Ctrl+Shift so any key combo that includes that pair (including select-by-word!) will swap your keyboard layout too.
Sometimes I'd remote into a machine and after dozens of failed password attempts realize I was being treated to Double Dvorak, a much less well known layout in which the Qwerty -> Dvorak mapping is applied twice, due to the map being loaded both locally and remotely. This is all w/o third party software, literally nothing more than Windows just not coordinating with ... itself.
And finally, despite claims that Qwerty and Dvorak could be maintained at the same time, that wasn't true for me. The faster I got at Dvorak, the more speed and accuracy I lost on every other keyboard in the world I had to type on.
So now I'm typing this on Qwerty. It ain't as comfortable, but the number of hours I spend each week trying to get the computer to show which letter I'm pressing is now zero.
When working in offices I'd have my company supplied keyboard still plugged in as a guest keyboard so others could work with me seamlessly.
This also came about as windows used to have the most ridiculous behaviour of setting the layout per window, so if you changed it when someone else came over you'd end up in typing hell. They thankfully fixed this to be a global setting a few years back.
That being said, I don't regret anything and Colemak is way more comfortable, for me. I never typed "properly" in QWERTY, I would use every finger on my left hand, but only two on my right hand. I started to notice some pain in my right hand and so I tried to retrain myself to type properly, but it never lasted more than a day because I was typing half the speed with proper technique. The only way I could force myself to use a proper typing technique was to just completely switch the layout.
I also use it on my phone. Dvorak is terrible on swipe keyboards but I'm used to it.
It was annoying to learn but I forced myself to power though my initially slow typing speeds, and it was 100% worth it. I highly recommend it.
I switched to using copy and paste with the mouse with it since Cmd+c and Cmd+v are so hard to reach.
I don't use it myself - but on macOS there is a separate layout called "Dvorak - QWERTY Command" that shifts the layout to QWERTY when the command key is held to alleviate this issue.